Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScrollZoom handler setting tr.zoom = NaN #6924

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Fix ScrollZoom handler setting tr.zoom = NaN #6924

merged 2 commits into from
Jul 6, 2018

Conversation

anandthakker
Copy link
Contributor

Closes #6782
Closes #6486
Replaces #6921

@anandthakker anandthakker merged commit 2a66237 into master Jul 6, 2018
@anandthakker anandthakker deleted the fix-6782 branch July 6, 2018 18:30
@anandthakker anandthakker mentioned this pull request Jul 6, 2018
Closed
6 tasks
@hyperknot
Copy link

hyperknot commented Jul 6, 2018 •
edited
Loading

What about the assert(typeof zoom === 'number' && isFinite(zoom)) line you recommended? That's the one which actually makes sure that illegal matrices can never happen.

pirxpilot added a commit to pirxpilot/mapbox-gl-js that referenced this pull request Aug 9, 2018
@pirxpilot
fix exceptions resulting from uninitialized variable in scrollZoom
f14cab2 
see:
mapbox#6924

Closes mapbox#6782
Closes mapbox#6486
Replaces mapbox#6921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandthakker @hyperknot @jfirebaugh